Skip to content

fix(dependency-scan): add option to fail if bom file is empty#81

Merged
joker23 merged 1 commit into
mainfrom
skz/ensure-bom-files
Apr 23, 2026
Merged

fix(dependency-scan): add option to fail if bom file is empty#81
joker23 merged 1 commit into
mainfrom
skz/ensure-bom-files

Conversation

@joker23

@joker23 joker23 commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

This PR will add an optional input for the generate-sbom action to fail if the generated file is empty.

By default, this option is not enabled so existing workflows should not be affected. The reason for this option is that we caught a few workflow runs that silently passed due to having no empty bom files and not due to not having any violations.

This option could be use to ensure that your workflow is actually scanning for licenses.

See launchdarkly/js-core#1287

@joker23 joker23 marked this pull request as ready for review April 22, 2026 21:27
@joker23 joker23 requested a review from a team as a code owner April 22, 2026 21:27

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@joker23 joker23 merged commit 0a54234 into main Apr 23, 2026
5 checks passed
@joker23 joker23 deleted the skz/ensure-bom-files branch April 23, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants